Skip to content

Fusks with urls containing a hash are broken #36

Description

@DanAtkinson

This is definitely a longer term issue that needs some consideration because of the implications for existing users, and also because of the edge-case nature of it.

I subscribe to a few web comics whose authors have taken it upon themselves to put hashes in the filenames. For example:

http://www.example.com/comic-hall/Destructon-Issue-#03/03.jpg

If you try and 'fusk' this url, let's say 01-18, It will result in the following url in Chrome:

chrome-extension://glieaboaghdnlglpkekghloldikefofo/Html/images.htm#/fusk/http://www.example.com/comic-hall/Destructon-Issue-#03%2F%5B00-10%5D.jpg

And the url we try and work on is:

image

Unfortunately, there's no nice way of handling this in the address bar because if we try and url encode the hash, the server can (and does) decide that it doesn't match because it expects '#', rather than '%23'. Further, if we then try and url-decode the path, we might find that there are also urls that are supposed to contain url-encoded strings that are also treated as not found by the server.

Therefore, the only nice way of resolving this issue is to move the fusk url out of the address bar and into the page itself.

As part of this, I suggest that we consider allowing the url on the page to be editable so that the user can change their parameters to suit their needs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions