Add mintVehicle without device definition#222
Open
elffjs wants to merge 1 commit into
Open
Conversation
Adds a no-DD mint entry point that emits the existing VehicleNodeMinted event. Lays groundwork for retiring the DD-bearing mint variants once the off-chain device definition flow lands. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
elffjs
changed the title
Member
|
A+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reintroduce the vehicle minting function
mintVehicle(uint256 manufacturerNode, address owner, AttributeInfoPair[] attrInfo). This is exactly like the only minting function used by dimo-app-backend, except that it omits the device definition, which we're now storing offchain as a CloudEvent of typedimo.devicedefinitionattached to the DID for the NFT.We still accept attributes because we still use
imageURI.The function is simple but we still added a bunch of tests. The ABI was also regenerated.