Remove the on-chain vehicle device definition#221
Open
elffjs wants to merge 9 commits into
Open
Conversation
This is instead determined by the most recent attestation of type "dimo.attestation" having the vehicle NFT as its subject.
The version we picked up from the Streamr package seems to have been unpublished, maybe due to Shai-Hulud.
JamesReate
approved these changes
May 1, 2026
Remove registry.go in favor of the bindings/ directory.
This was a problem on main as well. I considered having these call, e.g., mintVehicle(manuf, owner, 0, attr), which would assign the default node. But I'm worried that storage concept will change soon and that these values will become liabilities.
zer0stars
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is instead determined by the most recent attestation of type "dimo.attestation" having the vehicle NFT as its subject.
Removed all
deviceDefinitionIdparameters for minting functions. Remove alldeviceDefinitionIdfields in EIP-712 messages. Rename these functions and messages if their names mentioned device definitions.