Assembler bug fix. Addresses #315#316
Merged
Merged
Conversation
…h is really the nzval in the CSC matrix gets overwritten. This was likely only an issue for csc/csr matrices on the CPU. Need to add options to not explicitly store this data when the backend is anything but CPU.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
==========================================
- Coverage 69.13% 68.85% -0.29%
==========================================
Files 55 55
Lines 5926 5969 +43
==========================================
+ Hits 4097 4110 +13
- Misses 1829 1859 +30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing bug where if we assembled stiffness and mass the cscnzval which is really the nzval in the CSC matrix gets overwritten. This was likely only an issue for csc/csr matrices on the CPU. Need to add options to not explicitly store this data when the backend is anything but CPU.
Fixes #315