Periodic BCs in DofManager#312
Merged
Merged
Conversation
…emblers. This is a push towards fully supporting periodic boundary conditions in multiple ways. This likely sped up set up times for update_dofs! due to the removal of insorted method calls in favor of a dof_to_unknown layout that explicitly flags dofs as unknowns, dirichlet bcs, or side_b periodic dofs. Also fixed a minor issue that showed in juliac with the new differentiable expression function capability.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 71.88% 71.35% -0.53%
==========================================
Files 53 53
Lines 5207 5321 +114
==========================================
+ Hits 3743 3797 +54
- Misses 1464 1524 +60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heavy rework of DofManager and how dofs are handled/calculated in ass…emblers. This is a push towards fully supporting periodic boundary conditions in multiple ways. This likely sped up set up times for update_dofs! due to the removal of insorted method calls in favor of a dof_to_unknown layout that explicitly flags dofs as unknowns, dirichlet bcs, or side_b periodic dofs. Also fixed a minor issue that showed in juliac with the new differentiable expression function capability.
Introduces function
which returns the unknown id when the dof is an unknown, -1 when it is a dof associated with a Dirichlet bc, and the side_a dof when the dof is a side_b dof in a periodic boundary condition.