Claude bugfixes#13
Open
aaronmoondewey wants to merge 4 commits into
Open
Conversation
…download_dewey_duck Preview path no longer paginates the full file manifest — hits page 1 of /v1/external/data/<id>/files directly via deweypy.api_request, unblocking preview_dewey_duck() on Visits-scale datasets where the manifest hang made it unusable. download_dewey_duck() now accepts partition_key_after and partition_key_before, threaded through to deweypy.get_dataset_files() so the manifest is server-side filtered before download — the missing piece researchers needed to pull a date-bounded slice on storage-limited setups. Hardens the R/Python boundary: structured JSON errors on stderr with non-zero exit, R surfaces them as stop() with the original message; empty-stdout treated as failure (covers system2 corner cases like uv crash before output); collision-proof __DEWEYR_NULL__ sentinel replaces "None" so user values like literal "None" round-trip safely; cols fallback now peeks the filtered URL set instead of an unfiltered preview. Adds 25 testthat tests (32 total, 0 failures) covering argv contract, partition_key validator gates, forwarding via local_mocked_bindings, and sentinel-collision regression. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
system2() silently drops empty-string elements from args, which shifts
every positional argv on the Python side. With Sys.getenv("DEWEY_API_KEY")
returning "" (e.g. an R session that didn't load .Renviron), this caused
data_id to be read as the sentinel string and produced a confusing 401
on data/__DEWEYR_NULL__/files instead of a clear "set your API key"
message. Reject empty / NA / non-character api_key and data_id at the
gate, with an actionable hint pointing to readRenviron().
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.