Skip to content

Review from Valentina #1

Description

@valenis96

Hello Marcelo, here you have your review!

  • First thing that I want to underline is the missing of the ReadMe, if you have some difficulty to develop it you can take a look here https://github.com/RichardLitt/standard-readme
  • The number of commits I think that is ok 👍
  • About the CSS code:
    • I suggest you to move the /* BODY */ style on the top because you are fixing the base of the all code and the order of the code in CSS is meaningful
    • You put the constants of colors on the top as the best practice wants, great! But pay attention to add there all the new colors that use during the rest of the code, to have all the colors that are present in the project in only one place
    • This is just a suggestion for the future that I like to use in the class naming: https://getbem.com/naming/
  • Pay attention of the interactivity of the page: the hovers are not correct, the buttons of the navbar become gray and the buttons of the various features should change color
  • The style of the navbar of the mobile mode is not correct

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions