Phase 16.5: Extract Camera magic numbers to named constexpr constants

[Cle2ment]

Camera.cpp contains hardcoded values:

• 0.002f mouse sensitivity (line 21)
• 0.3f rotation speed in GetRotationSpeed() (line 112)
• 5.0f move speed (line 38)
• glm::vec3(0, 1, 0) up direction (lines 35, 132)

Extract to named constexpr in Camera.h.

[github-actions]

Should they go in Constants.h or Camera.h?

The issue says Camera.h, which is correct — these are Camera-specific implementation details, unlike the domain-agnostic values in Constants.h (pi, epsilons). Adding them as static constexpr members of Camera (private) follows the existing pattern.

Note

The GetRotationSpeed() method (line 110-113) currently returns a magic number. After extraction, it should return kRotationSpeed. Consider whether that method is still needed vs. using the constant directly — but the issue doesn't ask for removal, so keep the method as a wrapper.

Additional extraction candidates (not in scope but worth noting)

There are other hardcoded values in Camera.cpp that could follow the same pattern in a follow-up:

• glm::vec3(0, 0, -1) — initial forward direction (line 14)
• glm::vec3(0, 0, 6) — initial position (line 15)
• 0.5f — pixel center offset (lines 149-150)
• 2.0f / -1.0f — NDC conversion range (line 152)

opencode session  |  github run