Convert UsernameService to UserService for extra flexibility

[JaseElder]

There are parts of the app that need more than just a username, like the product detail page, where the user's photo is displayed, and hydrating the UserInformation object, with review, follower, rating and awards numbers etc

Perhaps refactor the UsernameService to be a generic UserService?

[CherryCIC]

Thanks for this Jason. @JaseElder
I agree this is a valid point to raise!
I believe that UsernameService is/ will become far too narrow; particularly as the app is further developed.

I would support a refactoring of UsernameService into a more general UserService responsible for fetching lightweight public user/profile information by userId.

However... for MVP could this potentially be an overstep? @yusuphjoluwasen @MattGoodwin0 @fion21 may have considerations here.
Eventually the product detail page and seller-related UI will need more than just a username. They may need the seller photo, review count, follower count, rating, awards, and other lightweight public profile data.
If we keep extending UsernameService, it risks becoming misleading and awkward, because it will no longer only deal with usernames.

Let me know your thoughts, but to me this certainly seems an effective course of action which I can happily condone.

[JaseElder]

@CherryCIC the reason I raised it is because the seller photo and rating are in the current UI in the app, and are populated with dummy values:

user: UserInformation(
   username: sellerUsername,
   location: 'New York, USA',
   reviewsCount: 120,
   followersCount: 300,
   followingCount: 150,
   rating: 3.5,
   awards: 37,
   hasBuyerDiscounts: true,
),

So either the UI should be corrected to remove those elements for the MVP, or the service should be corrected to fetch the correct values for the MVP.