Skip to content

FIREFLY-2012: When UWS job fails, display (i) icon to popu job info dialog#1964

Open
loitly wants to merge 1 commit into
rc-2026.1from
FIREFLY-2012-jobinfo-on-table-error
Open

FIREFLY-2012: When UWS job fails, display (i) icon to popu job info dialog#1964
loitly wants to merge 1 commit into
rc-2026.1from
FIREFLY-2012-jobinfo-on-table-error

Conversation

@loitly
Copy link
Copy Markdown
Contributor

@loitly loitly commented May 22, 2026

Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-2012
Show "(i)" icon when UWS job failed

Test: https://fireflydev.ipac.caltech.edu/firefly-2012-jobinfo-on-table-error/firefly/

  • TAP -> Edit ADQL
  • ADQL Query: SELECT TOP 1000 * FROM a_dummy_table
  • Click Search

You should see an error message with the “(i)” icon that will pop up the Job Info Dialog.

@loitly loitly added this to the 2026.1 milestone May 22, 2026
@loitly loitly requested a review from jaladh-singhal May 22, 2026 17:43
@loitly loitly self-assigned this May 22, 2026
Copy link
Copy Markdown
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as expected.

I noticed a related issue (likely out of scope for this PR): when a job result (table) fails, there's no way to dismiss it. This is specifically annoying when this job was the first search you did because single table doesn't have table container toolbar to close the tab and you can't go back to empty results screen. I ran into same problem for spherex mosaic results and added two ways to overcome it:

  1. Use forceSingleTableAsTab:
    if (keys.length === 1 && !forceSingleTableAsTab) {
  2. Let the BGMaskPanel showError but give it the renderError:
    {renderError?.(errorMsg, infoButton) ?? defaultErrorContent}

I'm not sure if option 2 is possibe for general table case but if it is, it will save you from creating the job info button again in TablePanel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants