Skip to content

Bug: aggregated mail attachment merge references literal 'id' key #759

@somethingwithproof

Description

@somethingwithproof

Summary

In notification queue mail aggregation, attachment merge uses $emails['id']['attachments'] instead of $emails[$id]['attachments'].

Impact

  • Existing attachments for the current aggregation bucket may be skipped/lost.
  • Can trigger undefined-index notices depending on runtime settings.

Location

  • thold_functions.php, notification queue processing branch near:
$emails[$id]['attachments'] += array_merge($emails['id']['attachments'], $attachments);

Expected

Use the computed $id bucket and a proper merge strategy for attachment arrays.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions