From 78cdbee0252fa55bc02083b73bd16d1447d3cbbf Mon Sep 17 00:00:00 2001 From: rikardoricz Date: Tue, 21 Apr 2026 09:07:55 +0200 Subject: [PATCH 1/2] ci: exclude stub submodules and guard test-result step These submodules currently have empty package.xml: - safety_node - robot_localization - odrive_node tagged workarounds as TODO --- .github/workflows/ci.yml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6d4ab78..1b05b58 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,6 +38,19 @@ jobs: git rm -rf /var/lib/apt/lists/* + # TODO: drop entries once each submodule ships a valid package.xml. + # These submodules currently have empty manifests, which crash rosdep: + # - safety_node + # - robot_localization + # - odrive_node + - name: Exclude stub submodules from CI + shell: bash + run: | + for pkg in safety_node robot_localization odrive_node; do + rm -f "src/$pkg/package.xml" + touch "src/$pkg/COLCON_IGNORE" + done + - name: Resolve ROS dependencies (rosdep) shell: bash run: | @@ -72,6 +85,10 @@ jobs: if: always() shell: bash run: | + if [ ! -d build ]; then + echo "No build/ directory — skipping test-result." + exit 0 + fi source /opt/ros/humble/setup.bash colcon test-result --verbose @@ -98,6 +115,14 @@ jobs: with: submodules: recursive + # TODO: drop entries once each submodule ships a valid package.xml. + - name: Exclude stub submodules from rosdep scan + shell: bash + run: | + for pkg in safety_node robot_localization odrive_node; do + rm -f "src/$pkg/package.xml" + done + - name: Verify all package.xml dependencies resolve shell: bash run: | From ec0439d3147ed71b60dd77c945c60f91f7337979 Mon Sep 17 00:00:00 2001 From: rikardoricz Date: Tue, 21 Apr 2026 12:30:31 +0200 Subject: [PATCH 2/2] ci: drop colcon test until unit tests are written --- .github/workflows/ci.yml | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1b05b58..44eb5b9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,7 @@ concurrency: jobs: build: - name: colcon build & test + name: colcon build runs-on: ubuntu-latest container: image: ros:humble-ros-base @@ -72,25 +72,7 @@ jobs: --event-handlers console_cohesion+ \ --cmake-args -DCMAKE_BUILD_TYPE=Release - - name: colcon test - shell: bash - run: | - source /opt/ros/humble/setup.bash - source install/setup.bash - colcon test \ - --event-handlers console_cohesion+ \ - --return-code-on-test-failure - - - name: colcon test-result - if: always() - shell: bash - run: | - if [ ! -d build ]; then - echo "No build/ directory — skipping test-result." - exit 0 - fi - source /opt/ros/humble/setup.bash - colcon test-result --verbose + # TODO: re-enable colcon test once unit tests are written. - name: Upload build logs on failure if: failure()