Commit fa8e9d4
Ralph Kuepper
fix(web): address CodeRabbit review on the Jolt bridge + FFI validator
- constraintSixDofLockedTranslation now destroys its temporary
SixDOFConstraintSettings on every exit (including the API-absent path
where the constructor itself throws) and releases the body read-locks
exactly once via an idempotent finally, instead of leaking the settings
and double-releasing if registerConstraint threw.
- shapeHeightfield destroys its HeightFieldShapeSettings after Create().
- destroyWorld evicts this world's cached query filters (queryFilters())
and frees the native bp/obj/body/shape objects — previously one filter
set per (world, layer) queried leaked on every world teardown.
- validate-ffi.js strips block + line comments before scraping web FFI
signatures, so a commented-out `// pub fn bloom_old(...)` can't be read
as a real export and a trailing `x: f64 // note` can't break the
all-f64 arity check. Validator still: 0 failures, 0 warnings.1 parent 050a69f commit fa8e9d4
2 files changed
Lines changed: 32 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
228 | 238 | | |
229 | 239 | | |
230 | 240 | | |
| |||
924 | 934 | | |
925 | 935 | | |
926 | 936 | | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
927 | 943 | | |
928 | | - | |
| 944 | + | |
929 | 945 | | |
930 | 946 | | |
931 | 947 | | |
| |||
942 | 958 | | |
943 | 959 | | |
944 | 960 | | |
945 | | - | |
| 961 | + | |
946 | 962 | | |
947 | 963 | | |
948 | | - | |
949 | 964 | | |
950 | 965 | | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
951 | 969 | | |
952 | 970 | | |
953 | 971 | | |
| |||
1054 | 1072 | | |
1055 | 1073 | | |
1056 | 1074 | | |
1057 | | - | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
1058 | 1078 | | |
1059 | 1079 | | |
1060 | 1080 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
169 | | - | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
170 | 177 | | |
171 | 178 | | |
172 | 179 | | |
| |||
0 commit comments