You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR 描述注明"Rust tests/build not run locally because the Rust toolchain is unavailable",对应 CI run 为 action_required 且无日志,实际未运行。
Closing this PR. Summary (verified against current main f07b5b8a):
It reverts our already-merged fix 29072912 and reintroduces the V2 encryption bug. It re-adds the official_oauth_request gate that 29072912 deliberately removed. That gate is the root-cause condition: when the parent goes through a third-party relay (official backend behind it), the gate is false, message.encrypted is not stripped, the official backend behind the relay still encrypts message per the V2 schema and returns Fernet ciphertext, and the child fails with opaque_agent_payload_error. The correct check depends only on router composition (codex_multirouter_needs_plaintext_v2_collaboration), not on whether the parent's outbound is official OAuth. The PR also flips the test to assert the buggy behavior.
It does not compile. The diff appends a near-complete duplicate of codex.rs (5945 lines, 28 pub fn, starting with the file's own module header + use statements) to the end of codex.rs (E0428 duplicate definitions).
It was never compiled. The description states the Rust toolchain was unavailable locally, and the CI run is action_required with no logs.
If there is a genuine concern about the V2 fix, please raise it against the root-cause analysis rather than reverting it. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agents.*schemas to plaintext whenever the Codex MultiRouter has any third-party or ownership-ambiguous route.collaboration.*schemas and unrelated encrypted fields unchanged.Validation
git diff --check