[BUG] `cortex completion pwsh` is rejected even though Cortex internally treats `pwsh` as PowerShell

[prinws-11]

Project

cortex

Description

The explicit completion command uses clap_complete::Shell, which only accepts powershell, while Cortex’s own shell-detection helpers already recognize both powershell and pwsh as the same shell. This makes the CLI reject a shell name that the rest of Cortex already treats as valid.

Error Message

invalid value 'pwsh' for '[SHELL]'

Debug Logs

System Information

OS: Windows 10
RAM: 16 GB
CPU: Intel(R) Core(TM) i7-1165G7 @ 2.8GHz(8 CPUs), ~2.8GH

Screenshots

pwsh_o8BueHSZij.mp4

Steps to Reproduce

1. Run cortex completion pwsh.
2. Observe the argument parsing result.

Expected Behavior

pwsh should be accepted as an alias for PowerShell, consistent with Cortex’s internal shell detection.

Actual Behavior

The command rejects pwsh, even though other Cortex code paths map pwsh to PowerShell.

Additional Context

[echobt]

The issue reports that cortex completion pwsh is rejected because the command uses clap_complete::Shell which only accepts powershell, even though other parts of Cortex recognize pwsh as PowerShell.

I verified the codebase and found that src/cortex-cli/src/cli/args.rs defines the CompletionCommand with:

    /// Shell to generate completions for.
    #[arg(value_enum)]
    pub shell: Option<clap_complete::Shell>,

clap_complete::Shell only accepts the exact string powershell.

However, in other parts of the codebase, such as src/cortex-cli/src/cli/handlers.rs and src/cortex-engine/src/shell.rs, pwsh is explicitly mapped to PowerShell:

            "powershell" | "pwsh" => Shell::PowerShell,

            "powershell" | "pwsh" | "powershell.exe" | "pwsh.exe" => Self::PowerShell,

The screenshot is a video showing the user running cortex completion pwsh and receiving the error invalid value 'pwsh' for '[SHELL]'. This matches the description perfectly.

No exact duplicates were found. The issue is valid.

[GreyforgeLabs]

Implemented in CortexLM/cortex-code#405

Validation run:

• cargo test -p cortex-cli --test completion_pwsh --no-default-features --features cortex-tui -- --nocapture
• cargo check -p cortex-cli --no-default-features --features cortex-tui
• cargo fmt --package cortex-cli --check
• git diff --check
• git diff --cached --check

Note: direct completion generation in the debug test binary currently trips an unrelated existing clap debug assertion for a duplicated mcp ls alias, so the regression covers the parser and PowerShell install path without invoking the generator.