docs(1claw): per-org Bankr BYOK for key vending#458
Open
kmjones1979 wants to merge 3 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Replace stale BANKR_PARTNER_KEY-only wording with org settings and API config; note optional deployment fallback for self-hosted Vault. Co-authored-by: Cursor <cursoragent@cursor.com>
saltoriousSIG
approved these changes
Jun 8, 2026
saltoriousSIG
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed this from a public-skill security standpoint. Mostly fine, Ill approve, but please address the one item below:
- The deployment-level BANKR_PARTNER_KEY fallback can weaken tenant isolation if this runs in shared/self-hosted environments.
- It’s useful operationally, but it creates a bigger blast radius if org BYOK isn’t set and fallback is left on.
Proposed fix (doc it explicitly):
- fallback off by default in multi-tenant environments
- require explicit per-org opt-in to use fallback
- org BYOK always takes precedence over deployment fallback
- log whether each lease used org key vs fallback key
- alert when fallback is used in prod
Address maintainer review on PR BankrBot#458: multi-tenant should not use BANKR_PARTNER_KEY; org BYOK precedence, audit credential_source, and prod fallback alerting. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Thanks @saltoriousSIG — addressed the deployment-fallback tenant-isolation concern in commit 4c480e9: Docs (this PR)
Shipped in 1Claw Vault (separate deploy,
Org BYOK precedence was already enforced in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
1clawskill docs to match the shipped per-org Bankr BYOK model:bk_ptr_+ defaultwlt_via Settings → Bankr (PUT /v1/org/bankr-config)BANKR_PARTNER_KEYnoted as self-hosted fallback only1claw/SKILL.mdand1claw/references/mcp-and-api.mdFollow-up to #453 after 1Claw v0.33 BYOK landed in production.
Test plan
skills.bankr.bot/skills/1claw)Made with Cursor