Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Theme validation: add style.css metadata validations#8068

Merged
madhusudhand merged 4 commits into
trunkfrom
add-style-css-validations
Sep 10, 2024
Merged

Theme validation: add style.css metadata validations#8068
madhusudhand merged 4 commits into
trunkfrom
add-style-css-validations

Conversation

@madhusudhand

@madhusudhand madhusudhand commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

Changes proposed in this Pull Request:

This adds validations to style.css metadata values (missing and correctness).
It is observed that few themes are missing some of the required values or having invalid values.
This script should help find them.

Testing instructions:

  • Try setting invalid, or empty values for the style.css metadata
  • run the script npm run validate:theme <theme-name>
  • It should throw errors or warnings

Related issue(s):

This is an extension of #8039

@madhusudhand madhusudhand requested a review from ajlende September 4, 2024 11:07
@madhusudhand madhusudhand force-pushed the add-style-css-validations branch from dd8b121 to f22e84a Compare September 4, 2024 11:29
ajlende
ajlende reviewed Sep 4, 2024
View reviewed changes

@ajlende ajlende left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is organized. Just a couple minor comments that need addressing.

Comment thread theme-utils.mjs Outdated
Comment thread theme-utils.mjs Outdated
ajlende
ajlende approved these changes Sep 9, 2024
View reviewed changes

@ajlende ajlende left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a couple minor things to tweak before merging.

I ran it for all themes—filtering out just the messages—to get a high-level overview of the existing problems in the repo.

$ node theme-utils.mjs validate-theme --format=json $(find . -name 'style.css' | awk -F/ '{print $2}' | uniq | sort | paste -s -d, -) | jq '.[].data[].message' | sort | uniq -c | sort -bgr
5987 "must NOT have additional properties"
 734 "must be object"
 604 "must be string"
 348 "the $schema version does not match style.css 'Requires at least' version"
 191 "must match exactly one schema in oneOf"
  84 "must be equal to constant"
  75 "must be equal to one of the allowed values"
  74 "the 'Requires at least' version does not support theme.json"
  70 "https://automattic.com is not a valid Automattic author URI"
  58 "missing Requires PHP header metadata"
  57 null
  53 "missing Tested up to header metadata"
  47 "Missing $schema URI: undefined"
  32 "missing Requires at least header metadata"
  29 "LICENSE is not a valid URI"
  25 "WordPress 4.9.6 is not a valid version"
  18 "the WordPress team is not a valid author"
  12 "missing Theme URI header metadata"
  12 "https://wordpress.org/themes/ is not a valid Automattic author URI"
  11 "https://wordpress.com/themes/ is not a valid Automattic author URI"
  10 "1.0 is not a valid version"
   9 "https://wordpress.org/ is not a valid Automattic author URI"
   8 "http://wordpress.com/themes/ is not a valid Automattic author URI"
   6 "provide a valid version value"
   6 "property name must be valid"
   5 "must be number"
   5 "1.1 is not a valid version"
   4 "1.2 is not a valid version"
   3 "5.6.2 is not a valid version"
   2 "must be >= 1"
   2 "https://wordpress.org is not a valid Automattic author URI"
   2 "http://wordpress.com/themes is not a valid Automattic author URI"
   2 "http://automattic.com is not a valid Automattic author URI"
   2 "4.9.6 is not a valid version"
   2 "1.3 is not a valid version"
   1 "the theme is missing a style.css file"
   1 "the Automattic is not a valid author"
   1 "must have required property 'version'"
   1 "must have required property 'slug'"
   1 "must have required property 'name'"
   1 "license.txt is not a valid URI"
   1 "https://www.wordpress.com is not a valid Automattic author URI"
   1 "https://wordpress.org/themes/rebalance/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.org/themes/curriculum is not a valid Automattic author URI"
   1 "https://wordpress.org/themes/alter is not a valid Automattic author URI"
   1 "https://wordpress.com/theme/zoologist is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/xanadu is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/winkel is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/vivre is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/varia is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/upsidedown/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/ueno is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/twentytwentytwo-swiss is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/twentytwentytwo-red is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/twentytwentytwo-pink is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/twentytwentytwo-mint is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/twentytwentytwo-blue is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/tu/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/tronar/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/trellick/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/tomoni/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/tenaz/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/stratford is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/stow is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/storia/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/stewart is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/startfit/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/spiel is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/spearhead-blocks/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/spearhead is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/sophisticated-business is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/skatepark is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/shhh/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/shawburn is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/seedlet-blocks is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/seedlet is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/russell is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/ron is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/rockfield is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/rivington is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/reverie/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/remote is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/redhill is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/rainfall/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/quadrat is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/professional-business is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/pomme/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/poesis/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/pixl/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/pieria is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/perenne is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/pendant is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/paimio/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/overlaid is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/optimismo/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/nook is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/negai/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/mysa/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/muscat/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/morden is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/montagna/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/modern-business is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/meraki is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/maywood is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/mayland-blocks is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/mayland is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/masu/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/marl is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/luxus is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/luminance is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/luce is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/lowfi/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/loudness/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/lois/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/loic is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/livro is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/lineup/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/leven is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/lativ/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/kiosko/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/kingsley is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/kigen is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/kentwood/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/kaze/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/kansei/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/jinjang/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/jackson is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/infield is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/indice is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/ici/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/hey/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/hever is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/heiwa is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/hari is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/happening/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/grammerone/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/geologist is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/friendly-business is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/freddie/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/fotograma/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/fewer is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/feelingood/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/farrow is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/exmoor/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/exford is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/eventual/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/epi/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/entry is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/elegant-business is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/dorna is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/disco/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/dalston is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/ctlg is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/creatio-2 is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/creatio is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/craftfully is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/covr is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/coutoire is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/cortado is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/common is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/chanson/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/calvin is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/calm-business is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/cakely/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/bute/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/bsoj is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/brompton is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/boxedbio is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/blockbase is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/blank-canvas-blocks is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/blank-canvas-3/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/blank-canvas is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/bitacora is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/bibliophile/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/bibimbap/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/bennett is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/beep is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/bedrock is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/barnsbury is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/barnett is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/bark is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/balasana is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/azur is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/awburn is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/attar is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/assembler is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/artly is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/archivo/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/archeo is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/arbutus is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/appleton is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/antonia is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/ames is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/alves is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/aldente is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/theme/adventurer/ is not a valid WordPress.com theme URI"
   1 "https://wordpress.com/ is not a valid Automattic author URI"
   1 "https://wordpress.com is not a valid Automattic author URI"
   1 "https://themeshaper.com/vows/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/vitrum/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/trailblazer is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/the-shore/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/surrealist/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/stageplay/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/specials/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/recipebook/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/portia/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/pierian/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/partygurl/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/outnow/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/otis/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/onyxpulse/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/olympique/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/mymenu/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/musee/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/moviescript/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/maverick/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/matrioska/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/leancv/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/inversum/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/hola/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/grammer/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/fontaine/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/fixmate/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/expo/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/erma/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/dark-academia/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/cookbook/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/brightblog/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/blissed/ is not a valid WordPress.com theme URI"
   1 "https://themeshaper.com/atrium/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/the-menu/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/stage/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/raw/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/programme/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/organizer/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/messagerie/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/jazzers/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/issue/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/hall/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/curriculum/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/blogorama/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/alter/ is not a valid WordPress.com theme URI"
   1 "https://github.com/wordpress/allez/ is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/texty is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/sunderland is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/screenplay is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/saison is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/poema is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/nested is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/mpho is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/jaida is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/foam is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/farmhouse is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/dos is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/didone is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/block-canvas is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/tree/trunk/barnsbury23 is not a valid WordPress.com theme URI"
   1 "https://github.com/Automattic/themes/ is not a valid WordPress.com theme URI"
   1 "https://automatic.com is not a valid Automattic author URI"
   1 "http://www.andersnoren.se is not a valid Automattic author URI"
   1 "http://wordpress.com/themes/toujours/ is not a valid WordPress.com theme URI"
   1 "http://wordpress.com/themes/radcliffe-2 is not a valid WordPress.com theme URI"
   1 "http://wordpress.com/themes/libretto is not a valid WordPress.com theme URI"
   1 "http://wordpress.com/themes/libre-2/ is not a valid WordPress.com theme URI"
   1 "http://wordpress.com/themes/karuna/ is not a valid WordPress.com theme URI"
   1 "http://wordpress.com/themes/ixion/ is not a valid WordPress.com theme URI"
   1 "http://wordpress.com/themes/independent-publisher-2 is not a valid WordPress.com theme URI"
   1 "http://wordpress.com/themes/dyad-2/ is not a valid WordPress.com theme URI"
   1 "http://wordpress.com/themes/dara/ is not a valid WordPress.com theme URI"
   1 "http://wordpress.com/themes/button-2/ is not a valid WordPress.com theme URI"
   1 "http://wordpress.com/themes/affinity/ is not a valid WordPress.com theme URI"
   1 "http://wordpress.com/theme/textbook/ is not a valid WordPress.com theme URI"
   1 "http://wordpress.com/theme/lettre/ is not a valid WordPress.com theme URI"
   1 "http://theme.wordpress.com/themes/scratchpad is not a valid WordPress.com theme URI"
   1 "http://theme.wordpress.com/themes/lodestar is not a valid WordPress.com theme URI"
   1 "http://raamdev.com/ is not a valid Automattic author URI"
   1 "http://automattic.com/ is not a valid Automattic author URI"
   1 "Raam Dev is not a valid author"
   1 "Automattic, Inc is not a valid author"
   1 "Anders Norén is not a valid author"
   1 "6.6-RC4 is not a valid version"
   1 "5.7.2 is not a valid version"
   1 "1.4 is not a valid version"
   1 "1.17 is not a valid version"
   1 "/https://themeshaper.com/goodskin/ is not a valid WordPress.com theme URI"
   1 "/https://themeshaper.com/goodskin/ is not a valid URI"

Comment thread theme-utils.mjs Outdated
Comment thread theme-utils.mjs Outdated
@madhusudhand madhusudhand merged commit 1a54645 into trunk Sep 10, 2024
@madhusudhand madhusudhand deleted the add-style-css-validations branch September 10, 2024 07:40
@vcanales

vcanales commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

@madhusudhand This seems to have introduced a bug in the workflow:

https://github.com/Automattic/themes/actions/runs/10861752016/job/30144004760?pr=8154#step:5:9

Not sure what hasThemeJson was meant to be, but it's not there.

@vcanales vcanales mentioned this pull request Sep 17, 2024
Closed
@madhusudhand

madhusudhand commented Sep 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Not sure what hasThemeJson was meant to be, but it's not there.

Issue fixed in #8174. I did a rebase, and it is a success.

@dsas dsas mentioned this pull request Oct 18, 2024
Closed
@iamtakashi

iamtakashi commented Oct 18, 2024

Copy link
Copy Markdown
Contributor

Why does the theme URI need to be a dotcom site? Some themes could launch on dotorg first or not on dotcom at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ajlende ajlende ajlende approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@madhusudhand madhusudhand

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@madhusudhand @vcanales @iamtakashi @ajlende