Carousel: conflict with Gutenberg Lightbox behavior

[liviopv]

Impacted plugin

Jetpack

Quick summary

With the release of Lightbox for Image Blocks in the Gutenberg plugin, there's a conflict between Jetpack's Carousel and the core Lightbox behavior when using a core Gallery Block.

Somewhat similar to #19496 and #17484

Steps to reproduce

1. Turn on Carousel
2. Add a core Gallery Block
3. In the Image Block inside the Gallery Block, select "Lightbox" in Advanced > Behaviors
4. Open the post/page and click on the image - it will show Carousel first, and after a second click it will show GB's lightbox

A clear and concise description of what you expected to happen.

In core blocks, if I select the Lightbox behavior, it should use that instead of Carousel, as that action is more specific, since it's defined at block-level

What actually happened

Carousel was shown in the first click, and core's Lightbox after trying to exit, creating a confusing experience

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple, Atomic, Self-hosted

Logs or notes

WordPress 6.3, Gutenberg 16.5

[cuemarie]

📌 REPRODUCTION RESULTS

• Tested on Simple – Replicated
• Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
Replicated on GB 16.4.0 (on simple) and GB 16.5.0 (on AT). I believe the Image Block > Lightbox feature was released in an early 16.x update, so unclear if this is a new issue or just one that hasn't come up quite yet.

Atomic

CbTTxT.mp4

📌 ACTIONS

• Triage complete
• CC @jeherve

[jeherve]

TIL about the Lightbox feature in Gutenberg!

It was introduced in WordPress/gutenberg#50373

I'm not sure what should be our approach with this. Looking at Gutenberg's implementation, I would personally think that Jetpack's Carousel feature is more interesting, it offers more features and works better with multiple images. Maybe we should opt to disable Gutenberg's implementation when the Carousel feature is enabled.

I think we may be able to rely on the WP_Block_Supports class here, or maybe on the filter added here:
https://github.com/WordPress/gutenberg/blob/676f25961bfab695bacb5dd7ebb10443e49bce23/lib/block-supports/behaviors.php#L28-L35

@artemiomorales I see you worked on the initial implementation of the Lightbox. I'd be curious to have your take on this; do you think third-party plugins should be disabling Gutenberg's Lightbox when they offer a similar feature?