In your code from lines 334-348 (
|
final_coverage, best_step = None, None |
)
you seem to iterate over the different step size validation coverages and simply choose the first index>tolerance which is greater than (1 - val_significance) * 100. This can lead to trivial bands.
Consider the case where your smallest step gives you 99% validation coverage. By the current logic, you will choose the index as your step size and will thus get a trivial band.
Am I missing something?
In your code from lines 334-348 (
FeatureCP/conformal/icp.py
Line 334 in 71c1b1f
you seem to iterate over the different step size validation coverages and simply choose the first index>tolerance which is greater than (1 - val_significance) * 100. This can lead to trivial bands.
Consider the case where your smallest step gives you 99% validation coverage. By the current logic, you will choose the index as your step size and will thus get a trivial band.
Am I missing something?