Skip to content

Assorted Linting Errors #32

Description

@simojo

Description of Issue

The current code base needs the following linting errors resolved:

bosco/list_processing/combination.py:16: error: Incompatible return value type (got "List[Any]", expected "Tuple[Any]")
bosco/list_processing/search.py:22: error: Missing return statement
bosco/list_processing/search.py:76: error: Unsupported operand types for > ("int" and "Type[List[Any]]")
bosco/list_processing/search.py:76: error: Variable "pos" is not valid as a type
bosco/list_processing/search.py:76: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
bosco/list_processing/search.py:99: error: Argument 3 to "compute_recursive_binary_search" has incompatible type "float"; expected "int"
bosco/generate.py:16: error: List comprehension has incompatible type List[float]; expected List[int]
bosco/generate.py:20: error: List comprehension has incompatible type List[str]; expected List[int]
bosco/generate.py:27: error: Incompatible return value type (got "List[int]", expected "List[Union[int, float, str]]")
bosco/generate.py:27: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
bosco/generate.py:27: note: Consider using "Sequence" instead, which is covariant
bosco/generate.py:27: note: Perhaps you need a type annotation for "random_list"? Suggestion: "List[Union[int, float, str]]"
bosco/list_processing/basics.py:105: error: Function "builtins.callable" is not valid as a type
bosco/list_processing/basics.py:105: note: Perhaps you need "Callable[...]" or a callback protocol?
bosco/list_processing/basics.py:107: error: callable? not callable
bosco/list_processing/basics.py:110: error: Function "builtins.callable" is not valid as a type
bosco/list_processing/basics.py:110: note: Perhaps you need "Callable[...]" or a callback protocol?
bosco/list_processing/basics.py:112: error: callable? not callable
bosco/list_processing/basics.py:115: error: Function "builtins.callable" is not valid as a type
bosco/list_processing/basics.py:115: note: Perhaps you need "Callable[...]" or a callback protocol?
bosco/list_processing/basics.py:119: error: callable? not callable
bosco/main.py:40: error: Argument 3 to "run_sorting_algorithm" has incompatible type "List[Union[int, float, str]]"; expected "List[int]"

Steps to Reproduce

These errors were encounted when running poetry run task lint.

Proposed Solution

Go through each file and resolve each linting error individually.

Metadata

Metadata

Assignees

Labels

help wantedExtra attention is needed

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions