Add tests for register_service_with_metadata atomicity and the svc_reg event

[mikewheeleer]

Test the atomic registration-plus-metadata entrypoint

Description

register_service_with_metadata in contracts/escrow/src/lib.rs sets ServiceRegistered(service_id) = true and writes ServiceMetadata(service_id) in one admin-gated call, emitting svc_reg(service_id, owner). contracts/escrow/src/test.rs does not verify that both slots are set by the single call, that the event carries the owner, or that the entrypoint honours the admin and pause gates. This issue adds the missing coverage for the combined entrypoint.

Requirements and context

• Repository scope: Agentpay-Org/Agentpay-contracts only.
• Cover: after one call, is_service_registered is true AND get_service_metadata returns the exact description + owner; the svc_reg(service_id, owner) event is emitted via env.events().all().
• Cover: re-registering an existing id overwrites its metadata (idempotent overwrite); an empty description is accepted.
• Cover: a non-admin caller is rejected; calling while paused panics #4.
• Cover that the combined call is equivalent to the separate register_service + set_service_metadata sequence; test-only change unless a genuine bug surfaces.

Suggested execution

• Fork the repo and create a branch
• git checkout -b test/contracts-register-with-metadata-tests
• Implement changes
  • Write code in: contracts/escrow/src/lib.rs — no changes expected; only touch if a bug is found.
  • Write comprehensive tests in: contracts/escrow/src/test.rs — the atomicity, event, idempotency, and gate scenarios above.
  • Add documentation: note the covered behaviour in the test module header comment.
  • Include NatSpec-style doc comments (///) on any test helpers.
  • Validate security: registration and metadata land together; only admin can call.
• Test and commit

Test and commit

• Run cargo fmt --all -- --check, cargo build, and cargo test.
• Cover edge cases: overwrite existing service, empty description, paused contract, non-admin caller.
• Include the full cargo test output and a short security notes section in the PR description.

Example commit message

test: cover register_service_with_metadata atomicity and svc_reg event

Guidelines

• Minimum 95 percent test coverage for impacted modules.
• Clear, reviewer-focused documentation.
• Timeframe: 96 hours.

Community & contribution rewards

• 💬 Join the AgentPay community on Discord for questions, reviews, and faster merges: https://discord.gg/eXvRKkgcv
• ⭐ This is a GrantFox OSS / Official Campaign task and may be rewarded. When your PR is merged you'll be prompted to rate the project — if this issue and the maintainers helped you ship, we'd be grateful for a 5-star rating. Clear questions in Discord and tidy, well-tested PRs are the fastest path to a merge and a reward.

[gloskull]

Hello, I have 4 years of experience delivering solutions for projects like this, covering backend, frontend, and smart contract development. After carefully reviewing your requirements, I have a clear understanding of the task and am confident in my ability to deliver a clean, efficient, and thoroughly tested solution on time. I prioritize code quality, maintainability, and industry best practices throughout the development process.
My PR will be submitted in under 10hours.

[yunus-dev-codecrafter]

Hi! I've carefully reviewed the entire task description and fully understand the requirements and expected outcome.
I have experience working on similar tasks and I'm confident I can complete this within about an hour. I'd be happy to take ownership of this issue and submit a clean, well-tested solution promptly.
If it's available, please assign it to me. Thank you!

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox!

@yunus-dev-codecrafter's PR #143 was approved and merged by @mikewheeleer.

🏆 @yunus-dev-codecrafter: You earned 40 FoxPoints for this contribution! Your current tier: Builder (2,271 total points). Track your full progress on GrantFox.

👏 Great work, @yunus-dev-codecrafter! Keep contributing to Agentpay-Org.