Fix spurious "Cannot determine terminus type" debug message for asymmetric paired hits#73
Merged
Merged
Conversation
…c pairs Agent-Logs-Url: https://github.com/Adamtaranto/TIRmite/sessions/598bf89c-2ff7-40b0-b6bc-3fd0f36737e3 Co-authored-by: Adamtaranto <2160099+Adamtaranto@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Adamtaranto/TIRmite/sessions/598bf89c-2ff7-40b0-b6bc-3fd0f36737e3 Co-authored-by: Adamtaranto <2160099+Adamtaranto@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix debug message for unpaired hit in asymmetrical pair
Fix spurious "Cannot determine terminus type" debug message for asymmetric paired hits
Apr 20, 2026
Owner
|
@copilot fix failing tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi-pair
--pairing-mapruns,writeFlanksiterates over all models inhitIndex(which contains hits from every pair), but each call receives only the current pair'sPairingConfig. For models belonging to other pairs,_determine_terminus_typecorrectly returnsNone— but this incorrectly triggered the misleading debug message and silently skipped hits that are classifiable, just in their own pair's context.Changes
src/tirmite/tirmitetools.py— InwriteFlanks, precomputeconfig_models(the set ofleft_model/right_modelfor the current asymmetric config) before the unpaired hits loop. Models not in this set are silently skipped; they will be processed with the correct config in their own pair'swriteFlankscall.tests/test_flank_extraction.py— Addedtest_asymmetric_config_skips_foreign_models_silently: builds ahitIndexwith models from two asymmetric pairs, callswriteFlankswith one pair's config, and asserts that (a) only that pair's models produce flank files and (b) no "Cannot determine terminus type" log messages are emitted for the foreign models.